refactor: add missing explicit (non-dynamic) imports silence linter errors by anatoly-ryabchenko · Pull Request #719 · roboflow/rf-detr

anatoly-ryabchenko · 2026-02-22T11:09:46Z

What does this PR do?

import ast was missing from main.py
import torch was missing from datasets/_develop.py
this may not have caused runtime crashes, since dependencies were imported upstream, but it is a bad practice and adds linter errors. This PR fixes that.

Related Issue(s): N/A

Type of Change

Refactoring (no functional changes)

Testing

I have tested this change locally
I have added/updated tests for this change

Test details:
Linter errors disappear (tested with PyCharm), functionality not affected (training, export).

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code where necessary, particularly in hard-to-understand areas
My changes generate no new warnings or errors
I have updated the documentation accordingly (if applicable)

Additional Context

….py to silence linter errors

CLAassistant · 2026-02-22T11:09:55Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Borda
❌ anatoly-linqapp
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2026-02-22T11:45:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (5cc0de9) to head (80e35e5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #719    +/-   ##
=======================================
+ Coverage       76%    79%    +3%     
=======================================
  Files           97     97            
  Lines         7874   7874            
=======================================
+ Hits          5970   6223   +253     
+ Misses        1904   1651   -253

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Borda · 2026-02-22T11:45:12Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@anatoly-ryabchenko ^^

Copilot

Pull request overview

This PR adds explicit imports for ast in main.py and torch in datasets/_develop.py to resolve linter errors. While these imports are technically used in both files, adding the module-level torch import in _develop.py conflicts with the intentional lazy-loading design of the _SimpleDataset class.

Changes:

Added import ast to src/rfdetr/main.py (used for ast.literal_eval in argument parsing)
Added import torch to src/rfdetr/datasets/_develop.py (needed for torch.Tensor type hint)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/rfdetr/main.py	Adds missing `ast` import needed for `ast.literal_eval` call on line 1016
src/rfdetr/datasets/_develop.py	Adds module-level `torch` import for type hint, but conflicts with lazy loading design

Copilot · 2026-02-22T11:47:00Z

src/rfdetr/datasets/_develop.py

 from typing import Any, Generator, Optional, Tuple
 from urllib.request import urlretrieve

+import torch


Adding a module-level torch import conflicts with the documented design intention of _SimpleDataset. The class docstring explicitly states that it "does not pull in torch at module load time" (lines 44-46), and torch was intentionally imported locally within __getitem__ (line 72) to achieve lazy loading.

While the module-level import is needed for linter compatibility with the torch.Tensor type hint on line 70, this breaks the lazy loading behavior. Consider one of these alternatives:

Use a string literal for the type hint: def __getitem__(self, idx: int) -> Tuple["torch.Tensor", dict]: combined with from __future__ import annotations (already present)

Import torch conditionally using TYPE_CHECKING: if TYPE_CHECKING: import torch

Update the docstring to reflect that torch is now imported at module load time

Since this file already uses from __future__ import annotations (line 13), option 1 (string literal) would preserve the lazy loading behavior while satisfying linters.

anatoly-ryabchenko · 2026-02-22T13:20:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@anatoly-ryabchenko ^^

I have accepted the license agreement several times, but it still shows up as not signed.

This is my first PR for an open-source project, so I'm a bit new to this.
For now, I will move it to draft, and will re-open it when the issues are fixed:

Will check how Codecov checks coverage and why it's not passing.
Will change the torch import to make it dynamic.
Will also check how to cleanly fix other dynamic imports to not trigger linter.

Borda · 2026-03-24T12:57:37Z

I have accepted the license agreement several times, but it still shows up as not signed.

could you please share the screenshot :)

Borda · 2026-04-08T16:30:56Z

@anatoly-ryabchenko, friendly ping, do you think you will have a chance to finish this one? 🦝

anatoly-ryabchenko · 2026-04-08T17:03:42Z

@anatoly-ryabchenko, friendly ping, do you think you will have a chance to finish this one? 🦝

Sorry for a very long delay. Had a very busy time, but would be happy to finish this and look at other issues in a day or so. Thanks for the ping!

Borda · 2026-04-08T18:48:19Z

@anatoly-ryabchenko I can help, but since the CI is still waiting on the CLA, I would need you sharig prinscreen with you signed so I can move forward :)

anatoly-ryabchenko · 2026-04-08T20:02:17Z

@anatoly-ryabchenko I can help, but since the CI is still waiting on the CLA, I would need you sharig prinscreen with you signed so I can move forward :)

Borda · 2026-04-08T22:02:51Z

@anatoly-ryabchenko I can help, but since the CI is still waiting on the CLA, I would need you sharig prinscreen with you signed so I can move forward :)

Thank you!

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

src/rfdetr/datasets/_develop.py

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

src/rfdetr/datasets/_develop.py

…rrors (#719) * refactor: add explicit (non-dynamic) imports for _develop.py to silence linter errors * refactor: move `numpy`, `torch`, and `PIL` imports to top-level --------- Co-authored-by: Anatoly Ryabchenko <anatoly@linqapp.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: jirka <6035284+Borda@users.noreply.github.com>

refactor: add explicit (non-dynamic) imports for _develop.py and main…

fa3f3d2

….py to silence linter errors

anatoly-ryabchenko requested review from Borda, SkalskiP, isaacrob and probicheaux as code owners February 22, 2026 11:09

fix(pre-commit): 🎨 auto format pre-commit hooks

8ed14e7

Borda requested a review from Copilot February 22, 2026 11:44

Copilot started reviewing on behalf of Borda February 22, 2026 11:45 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

anatoly-ryabchenko marked this pull request as draft February 22, 2026 13:20

Borda force-pushed the develop branch from 8eba898 to c12ea16 Compare February 23, 2026 11:16

github-actions bot added the has conflicts label Mar 13, 2026

Borda force-pushed the develop branch 2 times, most recently from a39bebd to a6e6ca0 Compare March 13, 2026 16:41

github-actions bot removed the has conflicts label Mar 13, 2026

Borda force-pushed the develop branch from a6e6ca0 to 0485141 Compare March 13, 2026 17:07

github-actions bot added the has conflicts label Mar 13, 2026

Borda added the waiting on author label Mar 24, 2026

Borda previously approved these changes Apr 8, 2026

View reviewed changes

Borda marked this pull request as ready for review April 8, 2026 22:03

Borda requested a review from Copilot April 8, 2026 22:03

Copilot started reviewing on behalf of Borda April 8, 2026 22:03 View session

Merge branch 'develop' into explicit-imports

a15b030

Copilot AI reviewed Apr 8, 2026

View reviewed changes

src/rfdetr/datasets/_develop.py Show resolved Hide resolved

Borda dismissed their stale review via a15b030 April 8, 2026 22:05

github-actions bot removed the has conflicts label Apr 8, 2026

Borda requested a review from Copilot April 8, 2026 22:05

Copilot AI reviewed Apr 8, 2026

View reviewed changes

src/rfdetr/datasets/_develop.py Show resolved Hide resolved

refactor: move numpy, torch, and PIL imports to top-level

80e35e5

Borda approved these changes Apr 8, 2026

View reviewed changes

Borda merged commit 12ff10f into roboflow:develop Apr 8, 2026
24 of 25 checks passed

Conversation

anatoly-ryabchenko commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of Change

Testing

Checklist

Additional Context

Uh oh!

CLAassistant commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Borda commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

anatoly-ryabchenko commented Feb 22, 2026

Uh oh!

Borda commented Mar 24, 2026

Uh oh!

Borda commented Apr 8, 2026

Uh oh!

anatoly-ryabchenko commented Apr 8, 2026

Uh oh!

Borda commented Apr 8, 2026

Uh oh!

anatoly-ryabchenko commented Apr 8, 2026

Uh oh!

Borda commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anatoly-ryabchenko commented Feb 22, 2026 •

edited

Loading

CLAassistant commented Feb 22, 2026 •

edited

Loading

codecov bot commented Feb 22, 2026 •

edited

Loading